Skip to content

pyln-testing: move mnemonic dependency directly into pyln-testing#8876

Merged
sangbida merged 1 commit intoElementsProject:masterfrom
daywalker90:pyln-testing-mnemonic-fix
Mar 17, 2026
Merged

pyln-testing: move mnemonic dependency directly into pyln-testing#8876
sangbida merged 1 commit intoElementsProject:masterfrom
daywalker90:pyln-testing-mnemonic-fix

Conversation

@daywalker90
Copy link
Copy Markdown
Collaborator

When installing only pyln-testing, without the cln-meta package, it is missing the mnemonic dependency.

I noticed this in the currently broken nightly CI of the plugins repo and i'm pretty sure this will happen when pyln-testing is published to pypi aswell.

Since mnemonic is only used in pyln-testing it should be in it's pyproject.toml.

@daywalker90 daywalker90 requested a review from cdecker as a code owner February 2, 2026 08:09
@daywalker90 daywalker90 added this to the v26.04 milestone Mar 13, 2026
@daywalker90 daywalker90 force-pushed the pyln-testing-mnemonic-fix branch from dbdd0f5 to 09c4f8d Compare March 13, 2026 20:39
@sangbida sangbida self-requested a review March 16, 2026 02:01
@sangbida sangbida added the Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. label Mar 16, 2026
When installing only pyln-testing directly it is missing the mnemonic
dependency.

Changelog-None
@daywalker90 daywalker90 force-pushed the pyln-testing-mnemonic-fix branch from 09c4f8d to 90b65d0 Compare March 16, 2026 07:17
Copy link
Copy Markdown
Collaborator

@sangbida sangbida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change :)

@sangbida sangbida merged commit 2566266 into ElementsProject:master Mar 17, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status::Ready for Review The work has been completed and is now awaiting evaluation or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants